Parcourir la source

修复角色禁用权限不失效问题

RuoYi il y a 1 an
Parent
commit
75f3275e15

+ 3 - 0
ruoyi-common/ruoyi-common-core/src/main/java/com/ruoyi/common/core/constant/UserConstants.java

@@ -21,6 +21,9 @@ public class UserConstants
21
     /** 用户封禁状态 */
21
     /** 用户封禁状态 */
22
     public static final String USER_DISABLE = "1";
22
     public static final String USER_DISABLE = "1";
23
 
23
 
24
+    /** 角色正常状态 */
25
+    public static final String ROLE_NORMAL = "0";
26
+
24
     /** 角色封禁状态 */
27
     /** 角色封禁状态 */
25
     public static final String ROLE_DISABLE = "1";
28
     public static final String ROLE_DISABLE = "1";
26
 
29
 

+ 3 - 3
ruoyi-common/ruoyi-common-datascope/src/main/java/com/ruoyi/common/datascope/aspect/DataScopeAspect.java

@@ -6,6 +6,7 @@ import org.aspectj.lang.JoinPoint;
6
 import org.aspectj.lang.annotation.Aspect;
6
 import org.aspectj.lang.annotation.Aspect;
7
 import org.aspectj.lang.annotation.Before;
7
 import org.aspectj.lang.annotation.Before;
8
 import org.springframework.stereotype.Component;
8
 import org.springframework.stereotype.Component;
9
+import com.ruoyi.common.core.constant.UserConstants;
9
 import com.ruoyi.common.core.context.SecurityContextHolder;
10
 import com.ruoyi.common.core.context.SecurityContextHolder;
10
 import com.ruoyi.common.core.text.Convert;
11
 import com.ruoyi.common.core.text.Convert;
11
 import com.ruoyi.common.core.utils.StringUtils;
12
 import com.ruoyi.common.core.utils.StringUtils;
@@ -73,8 +74,7 @@ public class DataScopeAspect
73
             if (StringUtils.isNotNull(currentUser) && !currentUser.isAdmin())
74
             if (StringUtils.isNotNull(currentUser) && !currentUser.isAdmin())
74
             {
75
             {
75
                 String permission = StringUtils.defaultIfEmpty(controllerDataScope.permission(), SecurityContextHolder.getPermission());
76
                 String permission = StringUtils.defaultIfEmpty(controllerDataScope.permission(), SecurityContextHolder.getPermission());
76
-                dataScopeFilter(joinPoint, currentUser, controllerDataScope.deptAlias(),
77
-                        controllerDataScope.userAlias(), permission);
77
+                dataScopeFilter(joinPoint, currentUser, controllerDataScope.deptAlias(), controllerDataScope.userAlias(), permission);
78
             }
78
             }
79
         }
79
         }
80
     }
80
     }
@@ -103,7 +103,7 @@ public class DataScopeAspect
103
         for (SysRole role : user.getRoles())
103
         for (SysRole role : user.getRoles())
104
         {
104
         {
105
             String dataScope = role.getDataScope();
105
             String dataScope = role.getDataScope();
106
-            if (conditions.contains(dataScope))
106
+            if (conditions.contains(dataScope) || StringUtils.equals(role.getStatus(), UserConstants.ROLE_DISABLE))
107
             {
107
             {
108
                 continue;
108
                 continue;
109
             }
109
             }

+ 8 - 3
ruoyi-modules/ruoyi-system/src/main/java/com/ruoyi/system/service/impl/SysPermissionServiceImpl.java

@@ -6,6 +6,8 @@ import java.util.Set;
6
 import org.springframework.beans.factory.annotation.Autowired;
6
 import org.springframework.beans.factory.annotation.Autowired;
7
 import org.springframework.stereotype.Service;
7
 import org.springframework.stereotype.Service;
8
 import org.springframework.util.CollectionUtils;
8
 import org.springframework.util.CollectionUtils;
9
+import com.ruoyi.common.core.constant.UserConstants;
10
+import com.ruoyi.common.core.utils.StringUtils;
9
 import com.ruoyi.system.api.domain.SysRole;
11
 import com.ruoyi.system.api.domain.SysRole;
10
 import com.ruoyi.system.api.domain.SysUser;
12
 import com.ruoyi.system.api.domain.SysUser;
11
 import com.ruoyi.system.service.ISysMenuService;
13
 import com.ruoyi.system.service.ISysMenuService;
@@ -71,9 +73,12 @@ public class SysPermissionServiceImpl implements ISysPermissionService
71
                 // 多角色设置permissions属性,以便数据权限匹配权限
73
                 // 多角色设置permissions属性,以便数据权限匹配权限
72
                 for (SysRole role : roles)
74
                 for (SysRole role : roles)
73
                 {
75
                 {
74
-                    Set<String> rolePerms = menuService.selectMenuPermsByRoleId(role.getRoleId());
75
-                    role.setPermissions(rolePerms);
76
-                    perms.addAll(rolePerms);
76
+                    if (StringUtils.equals(role.getStatus(), UserConstants.ROLE_NORMAL))
77
+                    {
78
+                        Set<String> rolePerms = menuService.selectMenuPermsByRoleId(role.getRoleId());
79
+                        role.setPermissions(rolePerms);
80
+                        perms.addAll(rolePerms);
81
+                    }
77
                 }
82
                 }
78
             }
83
             }
79
             else
84
             else