浏览代码

优化代码

RuoYi 3 年之前
父节点
当前提交
b93c9bfc5d
共有 26 个文件被更改,包括 61 次插入79 次删除
  1. 3 4
      ruoyi-common/ruoyi-common-core/src/main/java/com/ruoyi/common/core/constant/UserConstants.java
  2. 7 3
      ruoyi-common/ruoyi-common-core/src/main/java/com/ruoyi/common/core/utils/DateUtils.java
  3. 1 1
      ruoyi-common/ruoyi-common-core/src/main/java/com/ruoyi/common/core/utils/uuid/Seq.java
  4. 2 3
      ruoyi-modules/ruoyi-system/src/main/java/com/ruoyi/system/controller/SysConfigController.java
  5. 2 2
      ruoyi-modules/ruoyi-system/src/main/java/com/ruoyi/system/controller/SysDeptController.java
  6. 2 3
      ruoyi-modules/ruoyi-system/src/main/java/com/ruoyi/system/controller/SysDictTypeController.java
  7. 2 2
      ruoyi-modules/ruoyi-system/src/main/java/com/ruoyi/system/controller/SysMenuController.java
  8. 4 5
      ruoyi-modules/ruoyi-system/src/main/java/com/ruoyi/system/controller/SysPostController.java
  9. 2 5
      ruoyi-modules/ruoyi-system/src/main/java/com/ruoyi/system/controller/SysProfileController.java
  10. 4 5
      ruoyi-modules/ruoyi-system/src/main/java/com/ruoyi/system/controller/SysRoleController.java
  11. 7 12
      ruoyi-modules/ruoyi-system/src/main/java/com/ruoyi/system/controller/SysUserController.java
  12. 3 12
      ruoyi-modules/ruoyi-system/src/main/java/com/ruoyi/system/controller/SysUserOnlineController.java
  13. 1 1
      ruoyi-modules/ruoyi-system/src/main/java/com/ruoyi/system/service/ISysConfigService.java
  14. 1 1
      ruoyi-modules/ruoyi-system/src/main/java/com/ruoyi/system/service/ISysDeptService.java
  15. 1 1
      ruoyi-modules/ruoyi-system/src/main/java/com/ruoyi/system/service/ISysDictTypeService.java
  16. 1 1
      ruoyi-modules/ruoyi-system/src/main/java/com/ruoyi/system/service/ISysMenuService.java
  17. 2 2
      ruoyi-modules/ruoyi-system/src/main/java/com/ruoyi/system/service/ISysPostService.java
  18. 2 2
      ruoyi-modules/ruoyi-system/src/main/java/com/ruoyi/system/service/ISysRoleService.java
  19. 3 3
      ruoyi-modules/ruoyi-system/src/main/java/com/ruoyi/system/service/ISysUserService.java
  20. 1 1
      ruoyi-modules/ruoyi-system/src/main/java/com/ruoyi/system/service/impl/SysConfigServiceImpl.java
  21. 1 1
      ruoyi-modules/ruoyi-system/src/main/java/com/ruoyi/system/service/impl/SysDeptServiceImpl.java
  22. 1 1
      ruoyi-modules/ruoyi-system/src/main/java/com/ruoyi/system/service/impl/SysDictTypeServiceImpl.java
  23. 1 1
      ruoyi-modules/ruoyi-system/src/main/java/com/ruoyi/system/service/impl/SysMenuServiceImpl.java
  24. 2 2
      ruoyi-modules/ruoyi-system/src/main/java/com/ruoyi/system/service/impl/SysPostServiceImpl.java
  25. 2 2
      ruoyi-modules/ruoyi-system/src/main/java/com/ruoyi/system/service/impl/SysRoleServiceImpl.java
  26. 3 3
      ruoyi-modules/ruoyi-system/src/main/java/com/ruoyi/system/service/impl/SysUserServiceImpl.java

+ 3 - 4
ruoyi-common/ruoyi-common-core/src/main/java/com/ruoyi/common/core/constant/UserConstants.java

@@ -60,10 +60,9 @@ public class UserConstants
60
     /** InnerLink组件标识 */
60
     /** InnerLink组件标识 */
61
     public final static String INNER_LINK = "InnerLink";
61
     public final static String INNER_LINK = "InnerLink";
62
 
62
 
63
-    /** 校验返回结果码 */
64
-    public final static String UNIQUE = "0";
65
-
66
-    public final static String NOT_UNIQUE = "1";
63
+    /** 校验是否唯一的返回标识 */
64
+    public final static boolean UNIQUE = true;
65
+    public final static boolean NOT_UNIQUE = false;
67
 
66
 
68
     /**
67
     /**
69
      * 用户名长度限制
68
      * 用户名长度限制

+ 7 - 3
ruoyi-common/ruoyi-common-core/src/main/java/com/ruoyi/common/core/utils/DateUtils.java

@@ -137,16 +137,20 @@ public class DateUtils extends org.apache.commons.lang3.time.DateUtils
137
     }
137
     }
138
 
138
 
139
     /**
139
     /**
140
-     * 计算两个时间差
140
+     * 计算时间差
141
+     *
142
+     * @param endTime 最后时间
143
+     * @param startTime 开始时间
144
+     * @return 时间差(天/小时/分钟)
141
      */
145
      */
142
-    public static String getDatePoor(Date endDate, Date nowDate)
146
+    public static String timeDistance(Date endDate, Date startTime)
143
     {
147
     {
144
         long nd = 1000 * 24 * 60 * 60;
148
         long nd = 1000 * 24 * 60 * 60;
145
         long nh = 1000 * 60 * 60;
149
         long nh = 1000 * 60 * 60;
146
         long nm = 1000 * 60;
150
         long nm = 1000 * 60;
147
         // long ns = 1000;
151
         // long ns = 1000;
148
         // 获得两个时间的毫秒时间差异
152
         // 获得两个时间的毫秒时间差异
149
-        long diff = endDate.getTime() - nowDate.getTime();
153
+        long diff = endDate.getTime() - startTime.getTime();
150
         // 计算差多少天
154
         // 计算差多少天
151
         long day = diff / nd;
155
         long day = diff / nd;
152
         // 计算差多少小时
156
         // 计算差多少小时

+ 1 - 1
ruoyi-common/ruoyi-common-core/src/main/java/com/ruoyi/common/core/utils/uuid/Seq.java

@@ -22,7 +22,7 @@ public class Seq
22
     private static AtomicInteger uploadSeq = new AtomicInteger(1);
22
     private static AtomicInteger uploadSeq = new AtomicInteger(1);
23
 
23
 
24
     // 机器标识
24
     // 机器标识
25
-    private static String machineCode = "A";
25
+    private static final String machineCode = "A";
26
 
26
 
27
     /**
27
     /**
28
      * 获取通用序列号
28
      * 获取通用序列号

+ 2 - 3
ruoyi-modules/ruoyi-system/src/main/java/com/ruoyi/system/controller/SysConfigController.java

@@ -12,7 +12,6 @@ import org.springframework.web.bind.annotation.PutMapping;
12
 import org.springframework.web.bind.annotation.RequestBody;
12
 import org.springframework.web.bind.annotation.RequestBody;
13
 import org.springframework.web.bind.annotation.RequestMapping;
13
 import org.springframework.web.bind.annotation.RequestMapping;
14
 import org.springframework.web.bind.annotation.RestController;
14
 import org.springframework.web.bind.annotation.RestController;
15
-import com.ruoyi.common.core.constant.UserConstants;
16
 import com.ruoyi.common.core.utils.poi.ExcelUtil;
15
 import com.ruoyi.common.core.utils.poi.ExcelUtil;
17
 import com.ruoyi.common.core.web.controller.BaseController;
16
 import com.ruoyi.common.core.web.controller.BaseController;
18
 import com.ruoyi.common.core.web.domain.AjaxResult;
17
 import com.ruoyi.common.core.web.domain.AjaxResult;
@@ -84,7 +83,7 @@ public class SysConfigController extends BaseController
84
     @PostMapping
83
     @PostMapping
85
     public AjaxResult add(@Validated @RequestBody SysConfig config)
84
     public AjaxResult add(@Validated @RequestBody SysConfig config)
86
     {
85
     {
87
-        if (UserConstants.NOT_UNIQUE.equals(configService.checkConfigKeyUnique(config)))
86
+        if (configService.checkConfigKeyUnique(config))
88
         {
87
         {
89
             return error("新增参数'" + config.getConfigName() + "'失败,参数键名已存在");
88
             return error("新增参数'" + config.getConfigName() + "'失败,参数键名已存在");
90
         }
89
         }
@@ -100,7 +99,7 @@ public class SysConfigController extends BaseController
100
     @PutMapping
99
     @PutMapping
101
     public AjaxResult edit(@Validated @RequestBody SysConfig config)
100
     public AjaxResult edit(@Validated @RequestBody SysConfig config)
102
     {
101
     {
103
-        if (UserConstants.NOT_UNIQUE.equals(configService.checkConfigKeyUnique(config)))
102
+        if (!configService.checkConfigKeyUnique(config))
104
         {
103
         {
105
             return error("修改参数'" + config.getConfigName() + "'失败,参数键名已存在");
104
             return error("修改参数'" + config.getConfigName() + "'失败,参数键名已存在");
106
         }
105
         }

+ 2 - 2
ruoyi-modules/ruoyi-system/src/main/java/com/ruoyi/system/controller/SysDeptController.java

@@ -77,7 +77,7 @@ public class SysDeptController extends BaseController
77
     @PostMapping
77
     @PostMapping
78
     public AjaxResult add(@Validated @RequestBody SysDept dept)
78
     public AjaxResult add(@Validated @RequestBody SysDept dept)
79
     {
79
     {
80
-        if (UserConstants.NOT_UNIQUE.equals(deptService.checkDeptNameUnique(dept)))
80
+        if (!deptService.checkDeptNameUnique(dept))
81
         {
81
         {
82
             return error("新增部门'" + dept.getDeptName() + "'失败,部门名称已存在");
82
             return error("新增部门'" + dept.getDeptName() + "'失败,部门名称已存在");
83
         }
83
         }
@@ -95,7 +95,7 @@ public class SysDeptController extends BaseController
95
     {
95
     {
96
         Long deptId = dept.getDeptId();
96
         Long deptId = dept.getDeptId();
97
         deptService.checkDeptDataScope(deptId);
97
         deptService.checkDeptDataScope(deptId);
98
-        if (UserConstants.NOT_UNIQUE.equals(deptService.checkDeptNameUnique(dept)))
98
+        if (!deptService.checkDeptNameUnique(dept))
99
         {
99
         {
100
             return error("修改部门'" + dept.getDeptName() + "'失败,部门名称已存在");
100
             return error("修改部门'" + dept.getDeptName() + "'失败,部门名称已存在");
101
         }
101
         }

+ 2 - 3
ruoyi-modules/ruoyi-system/src/main/java/com/ruoyi/system/controller/SysDictTypeController.java

@@ -12,7 +12,6 @@ import org.springframework.web.bind.annotation.PutMapping;
12
 import org.springframework.web.bind.annotation.RequestBody;
12
 import org.springframework.web.bind.annotation.RequestBody;
13
 import org.springframework.web.bind.annotation.RequestMapping;
13
 import org.springframework.web.bind.annotation.RequestMapping;
14
 import org.springframework.web.bind.annotation.RestController;
14
 import org.springframework.web.bind.annotation.RestController;
15
-import com.ruoyi.common.core.constant.UserConstants;
16
 import com.ruoyi.common.core.utils.poi.ExcelUtil;
15
 import com.ruoyi.common.core.utils.poi.ExcelUtil;
17
 import com.ruoyi.common.core.web.controller.BaseController;
16
 import com.ruoyi.common.core.web.controller.BaseController;
18
 import com.ruoyi.common.core.web.domain.AjaxResult;
17
 import com.ruoyi.common.core.web.domain.AjaxResult;
@@ -73,7 +72,7 @@ public class SysDictTypeController extends BaseController
73
     @PostMapping
72
     @PostMapping
74
     public AjaxResult add(@Validated @RequestBody SysDictType dict)
73
     public AjaxResult add(@Validated @RequestBody SysDictType dict)
75
     {
74
     {
76
-        if (UserConstants.NOT_UNIQUE.equals(dictTypeService.checkDictTypeUnique(dict)))
75
+        if (!dictTypeService.checkDictTypeUnique(dict))
77
         {
76
         {
78
             return error("新增字典'" + dict.getDictName() + "'失败,字典类型已存在");
77
             return error("新增字典'" + dict.getDictName() + "'失败,字典类型已存在");
79
         }
78
         }
@@ -89,7 +88,7 @@ public class SysDictTypeController extends BaseController
89
     @PutMapping
88
     @PutMapping
90
     public AjaxResult edit(@Validated @RequestBody SysDictType dict)
89
     public AjaxResult edit(@Validated @RequestBody SysDictType dict)
91
     {
90
     {
92
-        if (UserConstants.NOT_UNIQUE.equals(dictTypeService.checkDictTypeUnique(dict)))
91
+        if (!dictTypeService.checkDictTypeUnique(dict))
93
         {
92
         {
94
             return error("修改字典'" + dict.getDictName() + "'失败,字典类型已存在");
93
             return error("修改字典'" + dict.getDictName() + "'失败,字典类型已存在");
95
         }
94
         }

+ 2 - 2
ruoyi-modules/ruoyi-system/src/main/java/com/ruoyi/system/controller/SysMenuController.java

@@ -89,7 +89,7 @@ public class SysMenuController extends BaseController
89
     @PostMapping
89
     @PostMapping
90
     public AjaxResult add(@Validated @RequestBody SysMenu menu)
90
     public AjaxResult add(@Validated @RequestBody SysMenu menu)
91
     {
91
     {
92
-        if (UserConstants.NOT_UNIQUE.equals(menuService.checkMenuNameUnique(menu)))
92
+        if (!menuService.checkMenuNameUnique(menu))
93
         {
93
         {
94
             return error("新增菜单'" + menu.getMenuName() + "'失败,菜单名称已存在");
94
             return error("新增菜单'" + menu.getMenuName() + "'失败,菜单名称已存在");
95
         }
95
         }
@@ -109,7 +109,7 @@ public class SysMenuController extends BaseController
109
     @PutMapping
109
     @PutMapping
110
     public AjaxResult edit(@Validated @RequestBody SysMenu menu)
110
     public AjaxResult edit(@Validated @RequestBody SysMenu menu)
111
     {
111
     {
112
-        if (UserConstants.NOT_UNIQUE.equals(menuService.checkMenuNameUnique(menu)))
112
+        if (!menuService.checkMenuNameUnique(menu))
113
         {
113
         {
114
             return error("修改菜单'" + menu.getMenuName() + "'失败,菜单名称已存在");
114
             return error("修改菜单'" + menu.getMenuName() + "'失败,菜单名称已存在");
115
         }
115
         }

+ 4 - 5
ruoyi-modules/ruoyi-system/src/main/java/com/ruoyi/system/controller/SysPostController.java

@@ -12,7 +12,6 @@ import org.springframework.web.bind.annotation.PutMapping;
12
 import org.springframework.web.bind.annotation.RequestBody;
12
 import org.springframework.web.bind.annotation.RequestBody;
13
 import org.springframework.web.bind.annotation.RequestMapping;
13
 import org.springframework.web.bind.annotation.RequestMapping;
14
 import org.springframework.web.bind.annotation.RestController;
14
 import org.springframework.web.bind.annotation.RestController;
15
-import com.ruoyi.common.core.constant.UserConstants;
16
 import com.ruoyi.common.core.utils.poi.ExcelUtil;
15
 import com.ruoyi.common.core.utils.poi.ExcelUtil;
17
 import com.ruoyi.common.core.web.controller.BaseController;
16
 import com.ruoyi.common.core.web.controller.BaseController;
18
 import com.ruoyi.common.core.web.domain.AjaxResult;
17
 import com.ruoyi.common.core.web.domain.AjaxResult;
@@ -76,11 +75,11 @@ public class SysPostController extends BaseController
76
     @PostMapping
75
     @PostMapping
77
     public AjaxResult add(@Validated @RequestBody SysPost post)
76
     public AjaxResult add(@Validated @RequestBody SysPost post)
78
     {
77
     {
79
-        if (UserConstants.NOT_UNIQUE.equals(postService.checkPostNameUnique(post)))
78
+        if (!postService.checkPostNameUnique(post))
80
         {
79
         {
81
             return error("新增岗位'" + post.getPostName() + "'失败,岗位名称已存在");
80
             return error("新增岗位'" + post.getPostName() + "'失败,岗位名称已存在");
82
         }
81
         }
83
-        else if (UserConstants.NOT_UNIQUE.equals(postService.checkPostCodeUnique(post)))
82
+        else if (!postService.checkPostCodeUnique(post))
84
         {
83
         {
85
             return error("新增岗位'" + post.getPostName() + "'失败,岗位编码已存在");
84
             return error("新增岗位'" + post.getPostName() + "'失败,岗位编码已存在");
86
         }
85
         }
@@ -96,11 +95,11 @@ public class SysPostController extends BaseController
96
     @PutMapping
95
     @PutMapping
97
     public AjaxResult edit(@Validated @RequestBody SysPost post)
96
     public AjaxResult edit(@Validated @RequestBody SysPost post)
98
     {
97
     {
99
-        if (UserConstants.NOT_UNIQUE.equals(postService.checkPostNameUnique(post)))
98
+        if (!postService.checkPostNameUnique(post))
100
         {
99
         {
101
             return error("修改岗位'" + post.getPostName() + "'失败,岗位名称已存在");
100
             return error("修改岗位'" + post.getPostName() + "'失败,岗位名称已存在");
102
         }
101
         }
103
-        else if (UserConstants.NOT_UNIQUE.equals(postService.checkPostCodeUnique(post)))
102
+        else if (!postService.checkPostCodeUnique(post))
104
         {
103
         {
105
             return error("修改岗位'" + post.getPostName() + "'失败,岗位编码已存在");
104
             return error("修改岗位'" + post.getPostName() + "'失败,岗位编码已存在");
106
         }
105
         }

+ 2 - 5
ruoyi-modules/ruoyi-system/src/main/java/com/ruoyi/system/controller/SysProfileController.java

@@ -10,7 +10,6 @@ import org.springframework.web.bind.annotation.RequestMapping;
10
 import org.springframework.web.bind.annotation.RequestParam;
10
 import org.springframework.web.bind.annotation.RequestParam;
11
 import org.springframework.web.bind.annotation.RestController;
11
 import org.springframework.web.bind.annotation.RestController;
12
 import org.springframework.web.multipart.MultipartFile;
12
 import org.springframework.web.multipart.MultipartFile;
13
-import com.ruoyi.common.core.constant.UserConstants;
14
 import com.ruoyi.common.core.domain.R;
13
 import com.ruoyi.common.core.domain.R;
15
 import com.ruoyi.common.core.utils.StringUtils;
14
 import com.ruoyi.common.core.utils.StringUtils;
16
 import com.ruoyi.common.core.utils.file.FileTypeUtils;
15
 import com.ruoyi.common.core.utils.file.FileTypeUtils;
@@ -69,13 +68,11 @@ public class SysProfileController extends BaseController
69
         LoginUser loginUser = SecurityUtils.getLoginUser();
68
         LoginUser loginUser = SecurityUtils.getLoginUser();
70
         SysUser sysUser = loginUser.getSysUser();
69
         SysUser sysUser = loginUser.getSysUser();
71
         user.setUserName(sysUser.getUserName());
70
         user.setUserName(sysUser.getUserName());
72
-        if (StringUtils.isNotEmpty(user.getPhonenumber())
73
-                && UserConstants.NOT_UNIQUE.equals(userService.checkPhoneUnique(user)))
71
+        if (StringUtils.isNotEmpty(user.getPhonenumber()) && !userService.checkPhoneUnique(user))
74
         {
72
         {
75
             return error("修改用户'" + user.getUserName() + "'失败,手机号码已存在");
73
             return error("修改用户'" + user.getUserName() + "'失败,手机号码已存在");
76
         }
74
         }
77
-        else if (StringUtils.isNotEmpty(user.getEmail())
78
-                && UserConstants.NOT_UNIQUE.equals(userService.checkEmailUnique(user)))
75
+        else if (StringUtils.isNotEmpty(user.getEmail()) && !userService.checkEmailUnique(user))
79
         {
76
         {
80
             return error("修改用户'" + user.getUserName() + "'失败,邮箱账号已存在");
77
             return error("修改用户'" + user.getUserName() + "'失败,邮箱账号已存在");
81
         }
78
         }

+ 4 - 5
ruoyi-modules/ruoyi-system/src/main/java/com/ruoyi/system/controller/SysRoleController.java

@@ -12,7 +12,6 @@ import org.springframework.web.bind.annotation.PutMapping;
12
 import org.springframework.web.bind.annotation.RequestBody;
12
 import org.springframework.web.bind.annotation.RequestBody;
13
 import org.springframework.web.bind.annotation.RequestMapping;
13
 import org.springframework.web.bind.annotation.RequestMapping;
14
 import org.springframework.web.bind.annotation.RestController;
14
 import org.springframework.web.bind.annotation.RestController;
15
-import com.ruoyi.common.core.constant.UserConstants;
16
 import com.ruoyi.common.core.utils.poi.ExcelUtil;
15
 import com.ruoyi.common.core.utils.poi.ExcelUtil;
17
 import com.ruoyi.common.core.web.controller.BaseController;
16
 import com.ruoyi.common.core.web.controller.BaseController;
18
 import com.ruoyi.common.core.web.domain.AjaxResult;
17
 import com.ruoyi.common.core.web.domain.AjaxResult;
@@ -85,11 +84,11 @@ public class SysRoleController extends BaseController
85
     @PostMapping
84
     @PostMapping
86
     public AjaxResult add(@Validated @RequestBody SysRole role)
85
     public AjaxResult add(@Validated @RequestBody SysRole role)
87
     {
86
     {
88
-        if (UserConstants.NOT_UNIQUE.equals(roleService.checkRoleNameUnique(role)))
87
+        if (!roleService.checkRoleNameUnique(role))
89
         {
88
         {
90
             return error("新增角色'" + role.getRoleName() + "'失败,角色名称已存在");
89
             return error("新增角色'" + role.getRoleName() + "'失败,角色名称已存在");
91
         }
90
         }
92
-        else if (UserConstants.NOT_UNIQUE.equals(roleService.checkRoleKeyUnique(role)))
91
+        else if (!roleService.checkRoleKeyUnique(role))
93
         {
92
         {
94
             return error("新增角色'" + role.getRoleName() + "'失败,角色权限已存在");
93
             return error("新增角色'" + role.getRoleName() + "'失败,角色权限已存在");
95
         }
94
         }
@@ -108,11 +107,11 @@ public class SysRoleController extends BaseController
108
     {
107
     {
109
         roleService.checkRoleAllowed(role);
108
         roleService.checkRoleAllowed(role);
110
         roleService.checkRoleDataScope(role.getRoleId());
109
         roleService.checkRoleDataScope(role.getRoleId());
111
-        if (UserConstants.NOT_UNIQUE.equals(roleService.checkRoleNameUnique(role)))
110
+        if (!roleService.checkRoleNameUnique(role))
112
         {
111
         {
113
             return error("修改角色'" + role.getRoleName() + "'失败,角色名称已存在");
112
             return error("修改角色'" + role.getRoleName() + "'失败,角色名称已存在");
114
         }
113
         }
115
-        else if (UserConstants.NOT_UNIQUE.equals(roleService.checkRoleKeyUnique(role)))
114
+        else if (!roleService.checkRoleKeyUnique(role))
116
         {
115
         {
117
             return error("修改角色'" + role.getRoleName() + "'失败,角色权限已存在");
116
             return error("修改角色'" + role.getRoleName() + "'失败,角色权限已存在");
118
         }
117
         }

+ 7 - 12
ruoyi-modules/ruoyi-system/src/main/java/com/ruoyi/system/controller/SysUserController.java

@@ -17,7 +17,6 @@ import org.springframework.web.bind.annotation.RequestBody;
17
 import org.springframework.web.bind.annotation.RequestMapping;
17
 import org.springframework.web.bind.annotation.RequestMapping;
18
 import org.springframework.web.bind.annotation.RestController;
18
 import org.springframework.web.bind.annotation.RestController;
19
 import org.springframework.web.multipart.MultipartFile;
19
 import org.springframework.web.multipart.MultipartFile;
20
-import com.ruoyi.common.core.constant.UserConstants;
21
 import com.ruoyi.common.core.domain.R;
20
 import com.ruoyi.common.core.domain.R;
22
 import com.ruoyi.common.core.utils.StringUtils;
21
 import com.ruoyi.common.core.utils.StringUtils;
23
 import com.ruoyi.common.core.utils.poi.ExcelUtil;
22
 import com.ruoyi.common.core.utils.poi.ExcelUtil;
@@ -143,7 +142,7 @@ public class SysUserController extends BaseController
143
         {
142
         {
144
             return R.fail("当前系统没有开启注册功能!");
143
             return R.fail("当前系统没有开启注册功能!");
145
         }
144
         }
146
-        if (UserConstants.NOT_UNIQUE.equals(userService.checkUserNameUnique(sysUser)))
145
+        if (!userService.checkUserNameUnique(sysUser))
147
         {
146
         {
148
             return R.fail("保存用户'" + username + "'失败,注册账号已存在");
147
             return R.fail("保存用户'" + username + "'失败,注册账号已存在");
149
         }
148
         }
@@ -200,17 +199,15 @@ public class SysUserController extends BaseController
200
     @PostMapping
199
     @PostMapping
201
     public AjaxResult add(@Validated @RequestBody SysUser user)
200
     public AjaxResult add(@Validated @RequestBody SysUser user)
202
     {
201
     {
203
-        if (UserConstants.NOT_UNIQUE.equals(userService.checkUserNameUnique(user)))
202
+        if (!userService.checkUserNameUnique(user))
204
         {
203
         {
205
             return error("新增用户'" + user.getUserName() + "'失败,登录账号已存在");
204
             return error("新增用户'" + user.getUserName() + "'失败,登录账号已存在");
206
         }
205
         }
207
-        else if (StringUtils.isNotEmpty(user.getPhonenumber())
208
-                && UserConstants.NOT_UNIQUE.equals(userService.checkPhoneUnique(user)))
206
+        else if (StringUtils.isNotEmpty(user.getPhonenumber()) && !userService.checkPhoneUnique(user))
209
         {
207
         {
210
             return error("新增用户'" + user.getUserName() + "'失败,手机号码已存在");
208
             return error("新增用户'" + user.getUserName() + "'失败,手机号码已存在");
211
         }
209
         }
212
-        else if (StringUtils.isNotEmpty(user.getEmail())
213
-                && UserConstants.NOT_UNIQUE.equals(userService.checkEmailUnique(user)))
210
+        else if (StringUtils.isNotEmpty(user.getEmail()) && !userService.checkEmailUnique(user))
214
         {
211
         {
215
             return error("新增用户'" + user.getUserName() + "'失败,邮箱账号已存在");
212
             return error("新增用户'" + user.getUserName() + "'失败,邮箱账号已存在");
216
         }
213
         }
@@ -229,17 +226,15 @@ public class SysUserController extends BaseController
229
     {
226
     {
230
         userService.checkUserAllowed(user);
227
         userService.checkUserAllowed(user);
231
         userService.checkUserDataScope(user.getUserId());
228
         userService.checkUserDataScope(user.getUserId());
232
-        if (UserConstants.NOT_UNIQUE.equals(userService.checkUserNameUnique(user)))
229
+        if (!userService.checkUserNameUnique(user))
233
         {
230
         {
234
             return error("修改用户'" + user.getUserName() + "'失败,登录账号已存在");
231
             return error("修改用户'" + user.getUserName() + "'失败,登录账号已存在");
235
         }
232
         }
236
-        else if (StringUtils.isNotEmpty(user.getPhonenumber())
237
-                && UserConstants.NOT_UNIQUE.equals(userService.checkPhoneUnique(user)))
233
+        else if (StringUtils.isNotEmpty(user.getPhonenumber()) && !userService.checkPhoneUnique(user))
238
         {
234
         {
239
             return error("修改用户'" + user.getUserName() + "'失败,手机号码已存在");
235
             return error("修改用户'" + user.getUserName() + "'失败,手机号码已存在");
240
         }
236
         }
241
-        else if (StringUtils.isNotEmpty(user.getEmail())
242
-                && UserConstants.NOT_UNIQUE.equals(userService.checkEmailUnique(user)))
237
+        else if (StringUtils.isNotEmpty(user.getEmail()) && !userService.checkEmailUnique(user))
243
         {
238
         {
244
             return error("修改用户'" + user.getUserName() + "'失败,邮箱账号已存在");
239
             return error("修改用户'" + user.getUserName() + "'失败,邮箱账号已存在");
245
         }
240
         }

+ 3 - 12
ruoyi-modules/ruoyi-system/src/main/java/com/ruoyi/system/controller/SysUserOnlineController.java

@@ -49,24 +49,15 @@ public class SysUserOnlineController extends BaseController
49
             LoginUser user = redisService.getCacheObject(key);
49
             LoginUser user = redisService.getCacheObject(key);
50
             if (StringUtils.isNotEmpty(ipaddr) && StringUtils.isNotEmpty(userName))
50
             if (StringUtils.isNotEmpty(ipaddr) && StringUtils.isNotEmpty(userName))
51
             {
51
             {
52
-                if (StringUtils.equals(ipaddr, user.getIpaddr()) && StringUtils.equals(userName, user.getUsername()))
53
-                {
54
-                    userOnlineList.add(userOnlineService.selectOnlineByInfo(ipaddr, userName, user));
55
-                }
52
+                userOnlineList.add(userOnlineService.selectOnlineByInfo(ipaddr, userName, user));
56
             }
53
             }
57
             else if (StringUtils.isNotEmpty(ipaddr))
54
             else if (StringUtils.isNotEmpty(ipaddr))
58
             {
55
             {
59
-                if (StringUtils.equals(ipaddr, user.getIpaddr()))
60
-                {
61
-                    userOnlineList.add(userOnlineService.selectOnlineByIpaddr(ipaddr, user));
62
-                }
56
+                userOnlineList.add(userOnlineService.selectOnlineByIpaddr(ipaddr, user));
63
             }
57
             }
64
             else if (StringUtils.isNotEmpty(userName))
58
             else if (StringUtils.isNotEmpty(userName))
65
             {
59
             {
66
-                if (StringUtils.equals(userName, user.getUsername()))
67
-                {
68
-                    userOnlineList.add(userOnlineService.selectOnlineByUserName(userName, user));
69
-                }
60
+                userOnlineList.add(userOnlineService.selectOnlineByUserName(userName, user));
70
             }
61
             }
71
             else
62
             else
72
             {
63
             {

+ 1 - 1
ruoyi-modules/ruoyi-system/src/main/java/com/ruoyi/system/service/ISysConfigService.java

@@ -78,5 +78,5 @@ public interface ISysConfigService
78
      * @param config 参数信息
78
      * @param config 参数信息
79
      * @return 结果
79
      * @return 结果
80
      */
80
      */
81
-    public String checkConfigKeyUnique(SysConfig config);
81
+    public boolean checkConfigKeyUnique(SysConfig config);
82
 }
82
 }

+ 1 - 1
ruoyi-modules/ruoyi-system/src/main/java/com/ruoyi/system/service/ISysDeptService.java

@@ -89,7 +89,7 @@ public interface ISysDeptService
89
      * @param dept 部门信息
89
      * @param dept 部门信息
90
      * @return 结果
90
      * @return 结果
91
      */
91
      */
92
-    public String checkDeptNameUnique(SysDept dept);
92
+    public boolean checkDeptNameUnique(SysDept dept);
93
 
93
 
94
     /**
94
     /**
95
      * 校验部门是否有数据权限
95
      * 校验部门是否有数据权限

+ 1 - 1
ruoyi-modules/ruoyi-system/src/main/java/com/ruoyi/system/service/ISysDictTypeService.java

@@ -94,5 +94,5 @@ public interface ISysDictTypeService
94
      * @param dictType 字典类型
94
      * @param dictType 字典类型
95
      * @return 结果
95
      * @return 结果
96
      */
96
      */
97
-    public String checkDictTypeUnique(SysDictType dictType);
97
+    public boolean checkDictTypeUnique(SysDictType dictType);
98
 }
98
 }

+ 1 - 1
ruoyi-modules/ruoyi-system/src/main/java/com/ruoyi/system/service/ISysMenuService.java

@@ -140,5 +140,5 @@ public interface ISysMenuService
140
      * @param menu 菜单信息
140
      * @param menu 菜单信息
141
      * @return 结果
141
      * @return 结果
142
      */
142
      */
143
-    public String checkMenuNameUnique(SysMenu menu);
143
+    public boolean checkMenuNameUnique(SysMenu menu);
144
 }
144
 }

+ 2 - 2
ruoyi-modules/ruoyi-system/src/main/java/com/ruoyi/system/service/ISysPostService.java

@@ -47,7 +47,7 @@ public interface ISysPostService
47
      * @param post 岗位信息
47
      * @param post 岗位信息
48
      * @return 结果
48
      * @return 结果
49
      */
49
      */
50
-    public String checkPostNameUnique(SysPost post);
50
+    public boolean checkPostNameUnique(SysPost post);
51
 
51
 
52
     /**
52
     /**
53
      * 校验岗位编码
53
      * 校验岗位编码
@@ -55,7 +55,7 @@ public interface ISysPostService
55
      * @param post 岗位信息
55
      * @param post 岗位信息
56
      * @return 结果
56
      * @return 结果
57
      */
57
      */
58
-    public String checkPostCodeUnique(SysPost post);
58
+    public boolean checkPostCodeUnique(SysPost post);
59
 
59
 
60
     /**
60
     /**
61
      * 通过岗位ID查询岗位使用数量
61
      * 通过岗位ID查询岗位使用数量

+ 2 - 2
ruoyi-modules/ruoyi-system/src/main/java/com/ruoyi/system/service/ISysRoleService.java

@@ -65,7 +65,7 @@ public interface ISysRoleService
65
      * @param role 角色信息
65
      * @param role 角色信息
66
      * @return 结果
66
      * @return 结果
67
      */
67
      */
68
-    public String checkRoleNameUnique(SysRole role);
68
+    public boolean checkRoleNameUnique(SysRole role);
69
 
69
 
70
     /**
70
     /**
71
      * 校验角色权限是否唯一
71
      * 校验角色权限是否唯一
@@ -73,7 +73,7 @@ public interface ISysRoleService
73
      * @param role 角色信息
73
      * @param role 角色信息
74
      * @return 结果
74
      * @return 结果
75
      */
75
      */
76
-    public String checkRoleKeyUnique(SysRole role);
76
+    public boolean checkRoleKeyUnique(SysRole role);
77
 
77
 
78
     /**
78
     /**
79
      * 校验角色是否允许操作
79
      * 校验角色是否允许操作

+ 3 - 3
ruoyi-modules/ruoyi-system/src/main/java/com/ruoyi/system/service/ISysUserService.java

@@ -72,7 +72,7 @@ public interface ISysUserService
72
      * @param user 用户信息
72
      * @param user 用户信息
73
      * @return 结果
73
      * @return 结果
74
      */
74
      */
75
-    public String checkUserNameUnique(SysUser user);
75
+    public boolean checkUserNameUnique(SysUser user);
76
 
76
 
77
     /**
77
     /**
78
      * 校验手机号码是否唯一
78
      * 校验手机号码是否唯一
@@ -80,7 +80,7 @@ public interface ISysUserService
80
      * @param user 用户信息
80
      * @param user 用户信息
81
      * @return 结果
81
      * @return 结果
82
      */
82
      */
83
-    public String checkPhoneUnique(SysUser user);
83
+    public boolean checkPhoneUnique(SysUser user);
84
 
84
 
85
     /**
85
     /**
86
      * 校验email是否唯一
86
      * 校验email是否唯一
@@ -88,7 +88,7 @@ public interface ISysUserService
88
      * @param user 用户信息
88
      * @param user 用户信息
89
      * @return 结果
89
      * @return 结果
90
      */
90
      */
91
-    public String checkEmailUnique(SysUser user);
91
+    public boolean checkEmailUnique(SysUser user);
92
 
92
 
93
     /**
93
     /**
94
      * 校验用户是否允许操作
94
      * 校验用户是否允许操作

+ 1 - 1
ruoyi-modules/ruoyi-system/src/main/java/com/ruoyi/system/service/impl/SysConfigServiceImpl.java

@@ -189,7 +189,7 @@ public class SysConfigServiceImpl implements ISysConfigService
189
      * @return 结果
189
      * @return 结果
190
      */
190
      */
191
     @Override
191
     @Override
192
-    public String checkConfigKeyUnique(SysConfig config)
192
+    public boolean checkConfigKeyUnique(SysConfig config)
193
     {
193
     {
194
         Long configId = StringUtils.isNull(config.getConfigId()) ? -1L : config.getConfigId();
194
         Long configId = StringUtils.isNull(config.getConfigId()) ? -1L : config.getConfigId();
195
         SysConfig info = configMapper.checkConfigKeyUnique(config.getConfigKey());
195
         SysConfig info = configMapper.checkConfigKeyUnique(config.getConfigKey());

+ 1 - 1
ruoyi-modules/ruoyi-system/src/main/java/com/ruoyi/system/service/impl/SysDeptServiceImpl.java

@@ -171,7 +171,7 @@ public class SysDeptServiceImpl implements ISysDeptService
171
      * @return 结果
171
      * @return 结果
172
      */
172
      */
173
     @Override
173
     @Override
174
-    public String checkDeptNameUnique(SysDept dept)
174
+    public boolean checkDeptNameUnique(SysDept dept)
175
     {
175
     {
176
         Long deptId = StringUtils.isNull(dept.getDeptId()) ? -1L : dept.getDeptId();
176
         Long deptId = StringUtils.isNull(dept.getDeptId()) ? -1L : dept.getDeptId();
177
         SysDept info = deptMapper.checkDeptNameUnique(dept.getDeptName(), dept.getParentId());
177
         SysDept info = deptMapper.checkDeptNameUnique(dept.getDeptName(), dept.getParentId());

+ 1 - 1
ruoyi-modules/ruoyi-system/src/main/java/com/ruoyi/system/service/impl/SysDictTypeServiceImpl.java

@@ -210,7 +210,7 @@ public class SysDictTypeServiceImpl implements ISysDictTypeService
210
      * @return 结果
210
      * @return 结果
211
      */
211
      */
212
     @Override
212
     @Override
213
-    public String checkDictTypeUnique(SysDictType dict)
213
+    public boolean checkDictTypeUnique(SysDictType dict)
214
     {
214
     {
215
         Long dictId = StringUtils.isNull(dict.getDictId()) ? -1L : dict.getDictId();
215
         Long dictId = StringUtils.isNull(dict.getDictId()) ? -1L : dict.getDictId();
216
         SysDictType dictType = dictTypeMapper.checkDictTypeUnique(dict.getDictType());
216
         SysDictType dictType = dictTypeMapper.checkDictTypeUnique(dict.getDictType());

+ 1 - 1
ruoyi-modules/ruoyi-system/src/main/java/com/ruoyi/system/service/impl/SysMenuServiceImpl.java

@@ -335,7 +335,7 @@ public class SysMenuServiceImpl implements ISysMenuService
335
      * @return 结果
335
      * @return 结果
336
      */
336
      */
337
     @Override
337
     @Override
338
-    public String checkMenuNameUnique(SysMenu menu)
338
+    public boolean checkMenuNameUnique(SysMenu menu)
339
     {
339
     {
340
         Long menuId = StringUtils.isNull(menu.getMenuId()) ? -1L : menu.getMenuId();
340
         Long menuId = StringUtils.isNull(menu.getMenuId()) ? -1L : menu.getMenuId();
341
         SysMenu info = menuMapper.checkMenuNameUnique(menu.getMenuName(), menu.getParentId());
341
         SysMenu info = menuMapper.checkMenuNameUnique(menu.getMenuName(), menu.getParentId());

+ 2 - 2
ruoyi-modules/ruoyi-system/src/main/java/com/ruoyi/system/service/impl/SysPostServiceImpl.java

@@ -79,7 +79,7 @@ public class SysPostServiceImpl implements ISysPostService
79
      * @return 结果
79
      * @return 结果
80
      */
80
      */
81
     @Override
81
     @Override
82
-    public String checkPostNameUnique(SysPost post)
82
+    public boolean checkPostNameUnique(SysPost post)
83
     {
83
     {
84
         Long postId = StringUtils.isNull(post.getPostId()) ? -1L : post.getPostId();
84
         Long postId = StringUtils.isNull(post.getPostId()) ? -1L : post.getPostId();
85
         SysPost info = postMapper.checkPostNameUnique(post.getPostName());
85
         SysPost info = postMapper.checkPostNameUnique(post.getPostName());
@@ -97,7 +97,7 @@ public class SysPostServiceImpl implements ISysPostService
97
      * @return 结果
97
      * @return 结果
98
      */
98
      */
99
     @Override
99
     @Override
100
-    public String checkPostCodeUnique(SysPost post)
100
+    public boolean checkPostCodeUnique(SysPost post)
101
     {
101
     {
102
         Long postId = StringUtils.isNull(post.getPostId()) ? -1L : post.getPostId();
102
         Long postId = StringUtils.isNull(post.getPostId()) ? -1L : post.getPostId();
103
         SysPost info = postMapper.checkPostCodeUnique(post.getPostCode());
103
         SysPost info = postMapper.checkPostCodeUnique(post.getPostCode());

+ 2 - 2
ruoyi-modules/ruoyi-system/src/main/java/com/ruoyi/system/service/impl/SysRoleServiceImpl.java

@@ -146,7 +146,7 @@ public class SysRoleServiceImpl implements ISysRoleService
146
      * @return 结果
146
      * @return 结果
147
      */
147
      */
148
     @Override
148
     @Override
149
-    public String checkRoleNameUnique(SysRole role)
149
+    public boolean checkRoleNameUnique(SysRole role)
150
     {
150
     {
151
         Long roleId = StringUtils.isNull(role.getRoleId()) ? -1L : role.getRoleId();
151
         Long roleId = StringUtils.isNull(role.getRoleId()) ? -1L : role.getRoleId();
152
         SysRole info = roleMapper.checkRoleNameUnique(role.getRoleName());
152
         SysRole info = roleMapper.checkRoleNameUnique(role.getRoleName());
@@ -164,7 +164,7 @@ public class SysRoleServiceImpl implements ISysRoleService
164
      * @return 结果
164
      * @return 结果
165
      */
165
      */
166
     @Override
166
     @Override
167
-    public String checkRoleKeyUnique(SysRole role)
167
+    public boolean checkRoleKeyUnique(SysRole role)
168
     {
168
     {
169
         Long roleId = StringUtils.isNull(role.getRoleId()) ? -1L : role.getRoleId();
169
         Long roleId = StringUtils.isNull(role.getRoleId()) ? -1L : role.getRoleId();
170
         SysRole info = roleMapper.checkRoleKeyUnique(role.getRoleKey());
170
         SysRole info = roleMapper.checkRoleKeyUnique(role.getRoleKey());

+ 3 - 3
ruoyi-modules/ruoyi-system/src/main/java/com/ruoyi/system/service/impl/SysUserServiceImpl.java

@@ -165,7 +165,7 @@ public class SysUserServiceImpl implements ISysUserService
165
      * @return 结果
165
      * @return 结果
166
      */
166
      */
167
     @Override
167
     @Override
168
-    public String checkUserNameUnique(SysUser user)
168
+    public boolean checkUserNameUnique(SysUser user)
169
     {
169
     {
170
         Long userId = StringUtils.isNull(user.getUserId()) ? -1L : user.getUserId();
170
         Long userId = StringUtils.isNull(user.getUserId()) ? -1L : user.getUserId();
171
         SysUser info = userMapper.checkUserNameUnique(user.getUserName());
171
         SysUser info = userMapper.checkUserNameUnique(user.getUserName());
@@ -183,7 +183,7 @@ public class SysUserServiceImpl implements ISysUserService
183
      * @return
183
      * @return
184
      */
184
      */
185
     @Override
185
     @Override
186
-    public String checkPhoneUnique(SysUser user)
186
+    public boolean checkPhoneUnique(SysUser user)
187
     {
187
     {
188
         Long userId = StringUtils.isNull(user.getUserId()) ? -1L : user.getUserId();
188
         Long userId = StringUtils.isNull(user.getUserId()) ? -1L : user.getUserId();
189
         SysUser info = userMapper.checkPhoneUnique(user.getPhonenumber());
189
         SysUser info = userMapper.checkPhoneUnique(user.getPhonenumber());
@@ -201,7 +201,7 @@ public class SysUserServiceImpl implements ISysUserService
201
      * @return
201
      * @return
202
      */
202
      */
203
     @Override
203
     @Override
204
-    public String checkEmailUnique(SysUser user)
204
+    public boolean checkEmailUnique(SysUser user)
205
     {
205
     {
206
         Long userId = StringUtils.isNull(user.getUserId()) ? -1L : user.getUserId();
206
         Long userId = StringUtils.isNull(user.getUserId()) ? -1L : user.getUserId();
207
         SysUser info = userMapper.checkEmailUnique(user.getEmail());
207
         SysUser info = userMapper.checkEmailUnique(user.getEmail());